Cold storage wallets are more secure than online wallets.

Online wallets are convenient because of the instant access they offer.

For that portion of your cryptocurrencies that you do not need quick access because you are holding for a long term, it is better to store them on cold wallets.

Below is a link to a post disclosing a malware that can attack online wallets like Metamask and wallets on Exchanges